Remove /api prefix from all routes and fix CityId FK constraint

- Strip /api prefix from all endpoint routes - Make Show.CityId nullable (no longer required FK) - Drop CityId FK constraint and alter column to NULL at startup via raw SQL - Add migration MakeCityIdNullable for schema consistency - Update Show DTOs to reflect nullable CityId Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-27 20:32:55 +02:00
parent 6c1330e570
commit b3612f5bec
36 changed files with 111 additions and 36 deletions
@@ -7,5 +7,5 @@ public class CreateShowDto
    public string? Description { get; set; }
    public string? PyrotechnicImplementationPlan { get; set; }
    public DateTime? Date { get; set; }
-    public int CityId { get; set; }
+    public int? CityId { get; set; }
 }
@@ -8,5 +8,5 @@ public class ReadShowDto
    public string? Description { get; set; }
    public string? PyrotechnicImplementationPlan { get; set; }
    public DateTime? Date { get; set; }
-    public int CityId { get; set; }
+    public int? CityId { get; set; }
 }
@@ -8,7 +8,7 @@ public class CreateShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
 {
    public override void Configure()
    {
-        Post("/api/shows");
+        Post("/shows");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class DeleteShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
 {
    public override void Configure()
    {
-        Delete("/api/shows/{Id}");
+        Delete("/shows/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class GetAllShowsEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
 {
    public override void Configure()
    {
-        Get("/api/shows");
+        Get("/shows");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class GetShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoint<I
 {
    public override void Configure()
    {
-        Get("/api/shows/{Id}");
+        Get("/shows/{Id}");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class UpdateShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
 {
    public override void Configure()
    {
-        Put("/api/shows/{Id}");
+        Put("/shows/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class CreateSoundEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
 {
    public override void Configure()
    {
-        Post("/api/sounds");
+        Post("/sounds");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class DeleteSoundEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
 {
    public override void Configure()
    {
-        Delete("/api/sounds/{Id}");
+        Delete("/sounds/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class GetAllSoundsEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpo
 {
    public override void Configure()
    {
-        Get("/api/sounds");
+        Get("/sounds");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class GetSoundEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoint<
 {
    public override void Configure()
    {
-        Get("/api/sounds/{Id}");
+        Get("/sounds/{Id}");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class UpdateSoundEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
 {
    public override void Configure()
    {
-        Put("/api/sounds/{Id}");
+        Put("/sounds/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class CreateSoundCategoryEndpoint(PyroFetesDbContext pyroFetesDbContext)
 {
    public override void Configure()
    {
-        Post("/api/soundcategorys");
+        Post("/soundcategorys");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class DeleteSoundCategoryEndpoint(PyroFetesDbContext pf3DbContext) : Endp
 {
    public override void Configure()
    {
-        Delete("/api/soundcategorys/{Id}");
+        Delete("/soundcategorys/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class GetAllSoundCategorysEndpoint(PyroFetesDbContext pf3DbContext) : End
 {
    public override void Configure()
    {
-        Get("/api/soundcategorys");
+        Get("/soundcategorys");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class GetSoundCategoryEndpoint(PyroFetesDbContext pf3DbContext) : Endpoin
 {
    public override void Configure()
    {
-        Get("/api/soundcategorys/{Id}");
+        Get("/soundcategorys/{Id}");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class UpdateSoundCategoryEndpoint(PyroFetesDbContext pf3DbContext) : Endp
 {
    public override void Configure()
    {
-        Patch("/api/soundcategorys/{Id}/name");
+        Patch("/soundcategorys/{Id}/name");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class CreateSoundTimecodeEndpoint(PyroFetesDbContext pyroFetesDbContext)
 {
    public override void Configure()
    {
-        Post("/api/soundtimecodes");
+        Post("/soundtimecodes");
        AllowAnonymous();
    }

@@ -14,7 +14,7 @@ public class DeleteSoundTimecodeEndpoint(PyroFetesDbContext pyroFetesDbContext)
 {
    public override void Configure()
    {
-        Delete("/api/soundtimecodes/{ShowId}/{SoundId}");
+        Delete("/soundtimecodes/{ShowId}/{SoundId}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class GetAllSoundTimecodesEndpoint(PyroFetesDbContext pyroFetesDbContext)
 {
    public override void Configure()
    {
-        Get("/api/soundtimecodes");
+        Get("/soundtimecodes");
        AllowAnonymous();
    }

@@ -15,7 +15,7 @@ public class GetSoundTimecodeEndpoint(PyroFetesDbContext pyroFetesDbContext) : E
 {
    public override void Configure()
    {
-        Get("/api/soundtimecodes/{ShowId}/{SoundId}");
+        Get("/soundtimecodes/{ShowId}/{SoundId}");
        AllowAnonymous();
    }

@@ -18,7 +18,7 @@ public class UpdateSoundTimecodeEndpoint(PyroFetesDbContext pyroFetesDbContext)
 {
    public override void Configure()
    {
-        Put("/api/soundtimecodes/{ShowId}/{SoundId}");
+        Put("/soundtimecodes/{ShowId}/{SoundId}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class CreateStaffEndpoint(PyroFetesDbContext pf3DbContext):Endpoint<Creat
 {
    public override void Configure()
    {
-        Post("/api/staff");
+        Post("/staff");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class DeleteStaffEndpoint(PyroFetesDbContext pf3DbContext) : Endpoint<IdS
 {
    public override void Configure()
    {
-        Delete("/api/staff/{Id}");
+        Delete("/staff/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class GetAllStaffEndpoint(PyroFetesDbContext pf3DbContext) : EndpointWith
 {
    public override void Configure()
    {
-        Get("/api/staff");
+        Get("/staff");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class GetStaffEndpoint(PyroFetesDbContext pf3DbContext) : Endpoint<IdStaf
 {
    public override void Configure()
    {
-        Get("/api/staff/{Id}");
+        Get("/staff/{Id}");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class UpdateStaffEndpoint(PyroFetesDbContext pf3DbContext) : Endpoint<Upd
 {
    public override void Configure()
    {
-        Put("/api/staff/{Id}");
+        Put("/staff/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class CreateTruckEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
 {
    public override void Configure()
    {
-        Post("/api/trucks");
+        Post("/trucks");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class DeleteTruckEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
 {
    public override void Configure()
    {
-        Delete("/api/trucks/{Id}");
+        Delete("/trucks/{Id}");
        AllowAnonymous();
    }

@@ -8,7 +8,7 @@ public class GetAllTrucksEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpo
 {
    public override void Configure()
    {
-        Get("/api/trucks");
+        Get("/trucks");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class GetTruckEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoint<
 {
    public override void Configure()
    {
-        Get("/api/trucks/{Id}");
+        Get("/trucks/{Id}");
        AllowAnonymous();
    }

@@ -9,7 +9,7 @@ public class UpdateTruckEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
 {
    public override void Configure()
    {
-        Put("/api/trucks/{Id}");
+        Put("/trucks/{Id}");
        AllowAnonymous();
    }

@@ -0,0 +1,59 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace PyroFetes.Migrations
+{
+    /// <inheritdoc />
+    public partial class MakeCityIdNullable : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropForeignKey(
+                name: "FK_Shows_Cities_CityId",
+                table: "Shows");
+
+            migrationBuilder.AlterColumn<int>(
+                name: "CityId",
+                table: "Shows",
+                type: "int",
+                nullable: true,
+                oldClrType: typeof(int),
+                oldType: "int");
+
+            migrationBuilder.AddForeignKey(
+                name: "FK_Shows_Cities_CityId",
+                table: "Shows",
+                column: "CityId",
+                principalTable: "Cities",
+                principalColumn: "Id");
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropForeignKey(
+                name: "FK_Shows_Cities_CityId",
+                table: "Shows");
+
+            migrationBuilder.AlterColumn<int>(
+                name: "CityId",
+                table: "Shows",
+                type: "int",
+                nullable: false,
+                defaultValue: 0,
+                oldClrType: typeof(int),
+                oldType: "int",
+                oldNullable: true);
+
+            migrationBuilder.AddForeignKey(
+                name: "FK_Shows_Cities_CityId",
+                table: "Shows",
+                column: "CityId",
+                principalTable: "Cities",
+                principalColumn: "Id",
+                onDelete: ReferentialAction.Cascade);
+        }
+    }
+}
@@ -813,7 +813,7 @@ namespace PyroFetes.Migrations

                    SqlServerPropertyBuilderExtensions.UseIdentityColumn(b.Property<int>("Id"));

-                    b.Property<int>("CityId")
+                    b.Property<int?>("CityId")
                        .HasColumnType("int");

                    b.Property<DateOnly?>("Date")
@@ -1594,8 +1594,7 @@ namespace PyroFetes.Migrations
                    b.HasOne("PyroFetes.Models.City", "City")
                        .WithMany("Shows")
                        .HasForeignKey("CityId")
-                        .OnDelete(DeleteBehavior.Cascade)
-                        .IsRequired();
+                        .OnDelete(DeleteBehavior.ClientSetNull);

                    b.Navigation("City");
                });
@@ -13,7 +13,7 @@ public class Show
    // Link (path/URL/file name) to the pyrotechnic implementation plan
    [Required, MaxLength(500)] public string? PyrotechnicImplementationPlan { get; set; }
    
-    [Required] public int CityId { get; set; }
+    public int? CityId { get; set; }
    public City? City { get; set; }
    
    public List<ShowStaff>? ShowStaffs { get; set; }
@@ -13,6 +13,23 @@ builder.Services.SwaggerDocument();

 var app = builder.Build();

+using (var scope = app.Services.CreateScope())
+{
+    var db = scope.ServiceProvider.GetRequiredService<PyroFetesDbContext>();
+    db.Database.ExecuteSqlRaw("""
+        IF EXISTS (
+            SELECT 1 FROM sys.foreign_keys
+            WHERE name = 'FK_Shows_Cities_CityId' AND parent_object_id = OBJECT_ID('Shows')
+        )
+        ALTER TABLE Shows DROP CONSTRAINT FK_Shows_Cities_CityId
+        """);
+    db.Database.ExecuteSqlRaw("""
+        IF COL_LENGTH('Shows', 'CityId') IS NOT NULL
+        AND COLUMNPROPERTY(OBJECT_ID('Shows'), 'CityId', 'AllowsNull') = 0
+            ALTER TABLE Shows ALTER COLUMN CityId INT NULL
+        """);
+}
+
 if (app.Environment.IsDevelopment())
 {
    app.UseSwaggerGen();