cernont/PF3-fork
1
0
Fork 0
Code Pull Requests Activity

Fix FastEndpoints/Swagger wiring and missing required fields in DTOs

Browse Source 
- Register FastEndpoints, SwaggerDocument, DbContext in Program.cs
- Add DbContextOptions constructor to PyroFetesDbContext
- Add CityId to Show DTOs and endpoints (NOT NULL in DB)
- Add F4T2NumberApproval/F4T2ExpirationDate to Staff DTOs and endpoints
- Simplify DeleteShow to rely on DB cascade instead of manual includes
- Default NOT NULL string fields to empty string on create

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
timothe
2026-05-27 19:35:01 +02:00
parent 3a09bfc8ad
commit 6c1330e570
18 changed files with 70 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PyroFetes/Endpoints/Show/CreateShowEndpoint.cs
+7 -5
View File
@@ -16,11 +16,12 @@ public class CreateShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
{
var show = new PyroFetes.Models.Show
{
Name = req.Name,
Place = req.Place,
Name = req.Name ?? string.Empty,
Place = req.Place ?? string.Empty,
Description = req.Description,
PyrotechnicImplementationPlan = req.PyrotechnicImplementationPlan,
Date = req.Date.HasValue ? DateOnly.FromDateTime(req.Date.Value) : null
PyrotechnicImplementationPlan = req.PyrotechnicImplementationPlan ?? string.Empty,
Date = req.Date.HasValue ? DateOnly.FromDateTime(req.Date.Value) : null,
CityId = req.CityId
};
pyroFetesDbContext.Shows.Add(show);
@@ -33,7 +34,8 @@ public class CreateShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
Place = show.Place,
Description = show.Description,
PyrotechnicImplementationPlan = show.PyrotechnicImplementationPlan,
Date = show.Date.HasValue ? show.Date.Value.ToDateTime(TimeOnly.MinValue) : null
Date = show.Date.HasValue ? show.Date.Value.ToDateTime(TimeOnly.MinValue) : null,
CityId = show.CityId
};
await Send.OkAsync(result, ct);
PyroFetes/Endpoints/Show/DeleteShowEndpoint.cs
-16
View File
@@ -21,12 +21,6 @@ public class DeleteShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
}
var show = await pyroFetesDbContext.Shows
.Include(s => s.ShowTrucks)
.Include(s => s.ShowStaffs)
.Include(s => s.SoundTimecodes)
.Include(s => s.ProductTimecodes)
.Include(s => s.Contracts)
.Include(s => s.ShowMaterials)
.FirstOrDefaultAsync(s => s.Id == req.Id.Value, ct);
if (show is null)
@@ -35,16 +29,6 @@ public class DeleteShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
return;
}
// Supprimer les relations associées
if (show.ShowTrucks != null && show.ShowTrucks.Any())
{
pyroFetesDbContext.ShowTrucks.RemoveRange(show.ShowTrucks);
}
// Note: Les autres relations (ShowStaffs, SoundTimecodes, etc.) devront aussi être gérées
// en fonction de votre modèle de données et de vos règles métier
// Pour l'instant, je laisse juste ShowTrucks comme exemple
pyroFetesDbContext.Shows.Remove(show);
await pyroFetesDbContext.SaveChangesAsync(ct);
PyroFetes/Endpoints/Show/GetAllShowsEndpoint.cs
+2 -1
View File
@@ -22,7 +22,8 @@ public class GetAllShowsEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoi
Place = s.Place,
Description = s.Description,
PyrotechnicImplementationPlan = s.PyrotechnicImplementationPlan,
Date = s.Date.HasValue ? s.Date.Value.ToDateTime(TimeOnly.MinValue) : null
Date = s.Date.HasValue ? s.Date.Value.ToDateTime(TimeOnly.MinValue) : null,
CityId = s.CityId
})
.ToListAsync(ct);
PyroFetes/Endpoints/Show/GetShowEndpoint.cs
+2 -1
View File
@@ -30,7 +30,8 @@ public class GetShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoint<I
Place = s.Place,
Description = s.Description,
PyrotechnicImplementationPlan = s.PyrotechnicImplementationPlan,
Date = s.Date.HasValue ? s.Date.Value.ToDateTime(TimeOnly.MinValue) : null
Date = s.Date.HasValue ? s.Date.Value.ToDateTime(TimeOnly.MinValue) : null,
CityId = s.CityId
})
.FirstOrDefaultAsync(ct);
PyroFetes/Endpoints/Show/UpdateShowEndpoint.cs
+4 -6
View File
@@ -34,11 +34,8 @@ public class UpdateShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
show.Place = req.Place ?? show.Place;
show.Description = req.Description ?? show.Description;
show.PyrotechnicImplementationPlan = req.PyrotechnicImplementationPlan ?? show.PyrotechnicImplementationPlan;
if (req.Date.HasValue)
{
show.Date = DateOnly.FromDateTime(req.Date.Value);
}
if (req.CityId.HasValue) show.CityId = req.CityId.Value;
if (req.Date.HasValue) show.Date = DateOnly.FromDateTime(req.Date.Value);
await pyroFetesDbContext.SaveChangesAsync(ct);
@@ -49,7 +46,8 @@ public class UpdateShowEndpoint(PyroFetesDbContext pyroFetesDbContext) : Endpoin
Place = show.Place,
Description = show.Description,
PyrotechnicImplementationPlan = show.PyrotechnicImplementationPlan,
Date = show.Date.HasValue ? show.Date.Value.ToDateTime(TimeOnly.MinValue) : null
Date = show.Date.HasValue ? show.Date.Value.ToDateTime(TimeOnly.MinValue) : null,
CityId = show.CityId
};
await Send.OkAsync(result, ct);
PyroFetes/Endpoints/Staff/CreateStaffEndpoint.cs
+11 -7
View File
@@ -19,19 +19,23 @@ public class CreateStaffEndpoint(PyroFetesDbContext pf3DbContext):Endpoint<Creat
FirstName = req.FirstName,
LastName = req.LastName,
Profession = req.Profession,
Email = req.Email
Email = req.Email,
F4T2NumberApproval = req.F4T2NumberApproval,
F4T2ExpirationDate = req.F4T2ExpirationDate
};
pf3DbContext.Staffs.Add(staff);
await pf3DbContext.SaveChangesAsync(ct);
var result = new ReadStaffDto()
{
Id = staff.Id,
FirstName = req.FirstName,
LastName = req.LastName,
Profession = req.Profession,
Email = req.Email
FirstName = staff.FirstName,
LastName = staff.LastName,
Profession = staff.Profession,
Email = staff.Email,
F4T2NumberApproval = staff.F4T2NumberApproval,
F4T2ExpirationDate = staff.F4T2ExpirationDate
};
await Send.OkAsync(result, ct);
PyroFetes/Endpoints/Staff/GetAllStaffEndpoint.cs
+3 -1
View File
@@ -22,7 +22,9 @@ public class GetAllStaffEndpoint(PyroFetesDbContext pf3DbContext) : EndpointWith
FirstName = s.FirstName,
LastName = s.LastName,
Profession = s.Profession,
Email = s.Email
Email = s.Email,
F4T2NumberApproval = s.F4T2NumberApproval,
F4T2ExpirationDate = s.F4T2ExpirationDate
}).ToList();
await Send.OkAsync(result, ct);
PyroFetes/Endpoints/Staff/GetStaffEndpoint.cs
+3 -1
View File
@@ -23,7 +23,9 @@ public class GetStaffEndpoint(PyroFetesDbContext pf3DbContext) : Endpoint<IdStaf
FirstName = s.FirstName,
LastName = s.LastName,
Profession = s.Profession,
Email = s.Email
Email = s.Email,
F4T2NumberApproval = s.F4T2NumberApproval,
F4T2ExpirationDate = s.F4T2ExpirationDate
})
.FirstOrDefaultAsync(ct);
PyroFetes/Endpoints/Staff/UpdateStaffEndpoint.cs
+10 -5
View File
@@ -22,10 +22,13 @@ public class UpdateStaffEndpoint(PyroFetesDbContext pf3DbContext) : Endpoint<Upd
return;
}
staff.FirstName = req.FirstName;
staff.LastName = req.LastName;
staff.Profession = req.Profession;
staff.Email = req.Email;
staff.FirstName = req.FirstName ?? staff.FirstName;
staff.LastName = req.LastName ?? staff.LastName;
staff.Profession = req.Profession ?? staff.Profession;
staff.Email = req.Email ?? staff.Email;
staff.F4T2NumberApproval = req.F4T2NumberApproval ?? staff.F4T2NumberApproval;
if (req.F4T2ExpirationDate.HasValue)
staff.F4T2ExpirationDate = req.F4T2ExpirationDate.Value;
await pf3DbContext.SaveChangesAsync(ct);
@@ -35,7 +38,9 @@ public class UpdateStaffEndpoint(PyroFetesDbContext pf3DbContext) : Endpoint<Upd
FirstName = staff.FirstName,
LastName = staff.LastName,
Profession = staff.Profession,
Email = staff.Email
Email = staff.Email,
F4T2NumberApproval = staff.F4T2NumberApproval,
F4T2ExpirationDate = staff.F4T2ExpirationDate
};
await Send.OkAsync(result, ct);